Differential D11644

Remove TERM=dumb, which is causing difficult-to-reproduce hangs
ClosedPublic
Actions

Authored by epriestley on Feb 3 2015, 1:38 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7119: Find another workaround for the "dumb terminal" warnings which doesn't hang

Commits

Restricted Diffusion Commit
rP8e2f054fe435: Remove TERM=dumb, which is causing difficult-to-reproduce hangs

Summary

Ref T7119. Three users have now reported that this causes their systems to hang, so it's looking like the cure is worse than the disease.

Revert this until we can eventually reproduce and understand the hang.

Test Plan

Users running into issues have reported that this resolves things.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28023.Feb 3 2015, 1:38 PM

epriestley retitled this revision from to Remove TERM=dumb, which is causing difficult-to-reproduce hangs.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7119: Find another workaround for the "dumb terminal" warnings which doesn't hang.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 3 2015, 1:38 PM

btrahan accepted this revision.Feb 3 2015, 5:50 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Feb 3 2015, 5:50 PM

Closed by commit rP8e2f054fe435: Remove TERM=dumb, which is causing difficult-to-reproduce hangs (authored by epriestley, committed by epriestley). · Explain WhyFeb 3 2015, 5:54 PM

This revision was automatically updated to reflect the committed changes.

alexmv mentioned this in D17100: Set `TERM` to prevent `No entry for terminal type "unknown"` messages during fetch.Dec 21 2016, 10:58 PM

alexmv mentioned this in rP972604e0e59c: Set `TERM` to prevent `No entry for terminal type "unknown"` messages during….Dec 21 2016, 11:17 PM

Revision Contents
Changeset List

Path

Size

scripts/

repository/

commit_hook.php

9 lines

Diff 28035

View Options

scripts/repository/commit_hook.php

Remove TERM=dumb, which is causing difficult-to-reproduce hangsClosedPublicActions