This sets an icon for each config, makes it easier to scan.
Details
Details
- Reviewers
epriestley btrahan - Commits
- Restricted Diffusion Commit
rP99292c5c6a67: Use icons with Config Options page
Reload Config page, see all new icons
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- config-icons
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 4240 Build 4253: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
I'm a little hesitant about the potential for overloading here, but it looks like the application icons pretty much are all associated with application settings.
Comment Actions
Is there a simple way to group them (app config, phab config, mail config?). Breaking it into 2-3 boxes would help alleviate clutter.
Comment Actions
On the technical side, we've sort of been trying to remove as much of the config as we can and move what we can't remove (but is application settings) into Applications > Options (e.g., all of @btrahan's recent work with email turns a bunch of email Config into application settings). I think we can maybe get through ~100 of the ~200 settings like this, maybe.
That would remove a bunch of these groups, and then maybe we could reorganize what's left a little better. This is probably a ways out, though. There's some config I think we can delete outright (e.g., we have 7 gcdaemon.ttl settings which I believe are never useful and likely never adjusted). I want to at least shop this around a little bit with users first, though (maybe I'll pose a question in the change log, which I guess I'm due to write).
Upshot: maybe not worth reorganizing yet, since we'll hopefully have a different/easier problem in like 3-6 months, depending on how things go?