Page MenuHomePhabricator

Use icons with Config Options page
ClosedPublic

Authored by chad on Feb 2 2015, 5:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:25 AM
Unknown Object (File)
Apr 9 2024, 9:28 AM
Unknown Object (File)
Mar 10 2024, 5:54 PM
Unknown Object (File)
Feb 16 2024, 5:03 AM
Unknown Object (File)
Feb 8 2024, 2:29 PM
Unknown Object (File)
Feb 7 2024, 4:52 PM
Unknown Object (File)
Feb 7 2024, 4:52 PM
Unknown Object (File)
Feb 7 2024, 4:52 PM
Subscribers

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP99292c5c6a67: Use icons with Config Options page
Summary

This sets an icon for each config, makes it easier to scan.

Test Plan

Reload Config page, see all new icons

pasted_file (975×525 px, 158 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Use icons with Config Options page.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.

I'm a little hesitant about the potential for overloading here, but it looks like the application icons pretty much are all associated with application settings.

This revision is now accepted and ready to land.Feb 2 2015, 5:57 PM

Is there a simple way to group them (app config, phab config, mail config?). Breaking it into 2-3 boxes would help alleviate clutter.

On the technical side, we've sort of been trying to remove as much of the config as we can and move what we can't remove (but is application settings) into Applications > Options (e.g., all of @btrahan's recent work with email turns a bunch of email Config into application settings). I think we can maybe get through ~100 of the ~200 settings like this, maybe.

That would remove a bunch of these groups, and then maybe we could reorganize what's left a little better. This is probably a ways out, though. There's some config I think we can delete outright (e.g., we have 7 gcdaemon.ttl settings which I believe are never useful and likely never adjusted). I want to at least shop this around a little bit with users first, though (maybe I'll pose a question in the change log, which I guess I'm due to write).

Upshot: maybe not worth reorganizing yet, since we'll hopefully have a different/easier problem in like 3-6 months, depending on how things go?

This revision was automatically updated to reflect the committed changes.