Automatically make timeline + objectbox sit flush
ClosedPublic
Actions

Authored by chad on Feb 2 2015, 4:47 PM.

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rP93be937d90a3: Automatically make timeline + objectbox sit flush

Summary

Right now you have to know to setFlush on an ObjectBox preceding a timeline, we can make that automatic with CSS.

Test Plan

Test some Diffusion commit pages, boxes now site flush under timeline. Check Maniphest and Differential, no changes.

Diff Detail

Repository

rP Phabricator

Branch

timeline-boxes

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4238
Build 4251: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 27953.Feb 2 2015, 4:47 PM

chad retitled this revision from to Automatically make timeline + objectbox sit flush.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 2 2015, 4:47 PM

epriestley accepted this revision.Feb 2 2015, 5:24 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 2 2015, 5:24 PM

Closed by commit rP93be937d90a3: Automatically make timeline + objectbox sit flush (authored by chad, committed by chad). · Explain WhyFeb 2 2015, 5:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-timeline-view.css

4 lines

Diff 27953

View Options

resources/celerity/map.php