Page MenuHomePhabricator

Change PHUIPagedFormView to extend AphrontView
ClosedPublic

Authored by chad on Feb 2 2015, 3:58 AM.
Tags
None
Referenced Files
F18838424: D11608.id.diff
Mon, Oct 27, 10:40 AM
F18836126: D11608.diff
Sun, Oct 26, 10:25 PM
F18738687: D11608.id27932.diff
Wed, Oct 1, 4:36 PM
F18649787: D11608.diff
Sep 20 2025, 10:16 PM
F18620142: D11608.diff
Sep 15 2025, 4:23 AM
F18201476: D11608.id27933.diff
Aug 18 2025, 7:44 AM
F18194431: D11608.id.diff
Aug 17 2025, 10:09 AM
F18193675: D11608.id27932.diff
Aug 17 2025, 6:20 AM
Subscribers

Details

Summary

Debugging crumbs in repository editing, and it seems there are stray divs that aren't used from extending AphrontTagView. I don't see any specific reason this needs to be from AphrontTagView, so changing it. Of course I'm not sure this is correct, so feel free to reject if I'm missing some obvious or non-obvious reasons.

Test Plan

Review editing a repositor, don't see extra div.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Change PHUIPagedFormView to extend AphrontView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 2 2015, 4:01 AM
This revision was automatically updated to reflect the committed changes.