Page MenuHomePhabricator
Differential D11601

Improve the usability of Phortune
ClosedPublic
Actions

Authored by epriestley on Feb 1 2015, 12:10 AM.
Tags
None
Referenced Files
F13223074: D11601.diff
Sun, May 19, 4:15 AM
F13216795: D11601.diff
Sat, May 18, 2:15 AM
F13206727: D11601.id27918.diff
Wed, May 15, 4:51 PM
Unknown Object (File)
Fri, May 3, 3:51 AM
Unknown Object (File)
Mon, Apr 29, 3:56 PM
Unknown Object (File)
Wed, Apr 24, 11:50 PM
Unknown Object (File)
Sun, Apr 21, 2:17 PM
Unknown Object (File)
Apr 19 2024, 4:42 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune
Commits
Restricted Diffusion Commit
rPf6015dbb56f7: Improve the usability of Phortune
Summary

Ref T6881.

  • Fix dead links.
  • Let implementations provide more information.
  • Provide more information to implementations.
Test Plan

Links work, invoices show billing periods, fewer "Subscription 6" crumbs, all is well in the world.

Diff Detail

Repository
rP Phabricator
Branch
sub4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4211
Build 4224: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27899.Feb 1 2015, 12:10 AM
epriestley retitled this revision from to Improve the usability of Phortune.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune.
Herald added a subscriber: epriestley. · View Herald TranscriptFeb 1 2015, 12:10 AM
btrahan accepted this revision.Feb 1 2015, 5:29 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 1 2015, 5:29 PM
Closed by commit rPf6015dbb56f7: Improve the usability of Phortune (authored by epriestley, committed by epriestley). · Explain WhyFeb 1 2015, 8:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27899

View Options

src/applications/phortune/controller/PhortuneSubscriptionViewController.php

Loading...
View Options

src/applications/phortune/phid/PhortunePurchasePHIDType.php

Loading...
View Options

src/applications/phortune/product/PhortuneProductImplementation.php

Loading...
View Options

src/applications/phortune/product/PhortuneSubscriptionProduct.php

Loading...
View Options

src/applications/phortune/storage/PhortuneProduct.php

Loading...
View Options

src/applications/phortune/storage/PhortunePurchase.php

Loading...
View Options

src/applications/phortune/storage/PhortuneSubscription.php

Loading...
View Options

src/applications/phortune/subscription/PhortuneSubscriptionImplementation.php

Loading...
View Options

src/applications/phortune/view/PhortuneSubscriptionTableView.php

Loading...
View Options

src/applications/phortune/worker/PhortuneSubscriptionWorker.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php

Loading...
Phabricator · Built by Phacility