Page MenuHomePhabricator
Differential D11587

Minor tidying of `DivinerWorkflow` classes
ClosedPublic
Actions

Authored by joshuaspence on Jan 30 2015, 11:05 PM.
Tags
None
Referenced Files
F14059291: D11587.diff
Sun, Nov 17, 6:51 PM
F14046325: D11587.diff
Wed, Nov 13, 8:20 PM
F14036749: D11587.diff
Sun, Nov 10, 11:53 AM
F14021067: D11587.diff
Wed, Nov 6, 5:01 AM
F14005539: D11587.id27881.diff
Sun, Oct 27, 3:09 PM
Unknown Object (File)
Oct 6 2024, 8:41 AM
Unknown Object (File)
Oct 6 2024, 8:40 AM
Unknown Object (File)
Oct 6 2024, 8:40 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPec3964944944: Minor tidying of `DivinerWorkflow` classes
Summary

Minor tidying and modernizing a few things.

Test Plan

Ran ./bin/diviner atomize and ./bin/diviner generate.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27881.Jan 30 2015, 11:05 PM
joshuaspence retitled this revision from to Minor tidying of `DivinerWorkflow` classes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 30 2015, 11:05 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 31 2015, 2:25 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 31 2015, 2:25 PM
joshuaspence added inline comments.Feb 1 2015, 11:00 AM
src/applications/diviner/workflow/DivinerGenerateWorkflow.php
84–162

Maybe this stuff should be moved to a docblock comment or to a *.diviner file so that we actually generate this documentation?

Closed by commit rPec3964944944: Minor tidying of `DivinerWorkflow` classes (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 1 2015, 11:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diviner/
workflow/
26 lines
85 lines
18 lines

Diff 27907

View Options

src/applications/diviner/workflow/DivinerAtomizeWorkflow.php

Loading...
View Options

src/applications/diviner/workflow/DivinerGenerateWorkflow.php

Loading...
View Options

src/applications/diviner/workflow/DivinerWorkflow.php

Loading...
Phabricator · Built by Phacility