Page MenuHomePhabricator
Differential D11587

Minor tidying of `DivinerWorkflow` classes
ClosedPublic
Actions

Authored by joshuaspence on Jan 30 2015, 11:05 PM.
Tags
None
Referenced Files
F19507331: D11587.id.diff
Fri, Jan 9, 7:27 PM
F19507318: D11587.id.diff
Fri, Jan 9, 7:21 PM
F19507295: D11587.id.diff
Fri, Jan 9, 7:08 PM
F19473689: D11587.id27907.diff
Wed, Jan 7, 4:59 PM
F19473632: D11587.id27907.diff
Wed, Jan 7, 4:53 PM
F19473576: D11587.id27907.diff
Wed, Jan 7, 4:49 PM
F19469180: D11587.diff
Sun, Jan 4, 5:41 PM
F19278119: D11587.id.diff
Tue, Dec 23, 2:10 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPec3964944944: Minor tidying of `DivinerWorkflow` classes
Summary

Minor tidying and modernizing a few things.

Test Plan

Ran ./bin/diviner atomize and ./bin/diviner generate.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27881.Jan 30 2015, 11:05 PM
joshuaspence retitled this revision from to Minor tidying of `DivinerWorkflow` classes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 30 2015, 11:05 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 31 2015, 2:25 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 31 2015, 2:25 PM
joshuaspence added inline comments.Feb 1 2015, 11:00 AM
src/applications/diviner/workflow/DivinerGenerateWorkflow.php
84–162

Maybe this stuff should be moved to a docblock comment or to a *.diviner file so that we actually generate this documentation?

Closed by commit rPec3964944944: Minor tidying of `DivinerWorkflow` classes (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 1 2015, 11:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diviner/
workflow/
26 lines
85 lines
18 lines

Diff 27907

View Options

src/applications/diviner/workflow/DivinerAtomizeWorkflow.php

Loading...
View Options

src/applications/diviner/workflow/DivinerGenerateWorkflow.php

Loading...
View Options

src/applications/diviner/workflow/DivinerWorkflow.php

Loading...
Phabricator · Built by Phacility