Page MenuHomePhabricator
Differential D11575

Make it possible for applications to generate concrete subscriptions
ClosedPublic
Actions

Authored by epriestley on Jan 30 2015, 12:52 AM.
Tags
None
Referenced Files
F13811349: D11575.diff
Wed, Sep 18, 3:24 AM
F13809399: D11575.diff
Tue, Sep 17, 7:47 AM
Unknown Object (File)
Fri, Sep 13, 2:37 PM
Unknown Object (File)
Mon, Sep 2, 6:33 AM
Unknown Object (File)
Sun, Sep 1, 7:15 AM
Unknown Object (File)
Sun, Sep 1, 2:37 AM
Unknown Object (File)
Sun, Sep 1, 2:37 AM
Unknown Object (File)
Sun, Sep 1, 2:37 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune
Commits
Restricted Diffusion Commit
rP4adc2d8a72fc: Make it possible for applications to generate concrete subscriptions
Summary

Ref T6881. This still doesn't "work" in any reasonable sense of the word, but gets us a bit further.

I'll build out the Phortune UI a little bit next, then look at implementing the Worker to do actual billing.

Test Plan
  • Allocated an instance and saw a Subscription generate properly.
  • Saw subscription show up in the Phortune UI, albeit in a very limited way.

Diff Detail

Repository
rP Phabricator
Branch
sub1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4186
Build 4199: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27853.Jan 30 2015, 12:52 AM
epriestley retitled this revision from to Make it possible for applications to generate concrete subscriptions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 30 2015, 12:52 AM
epriestley added inline comments.Jan 30 2015, 1:08 AM
src/applications/phortune/storage/PhortuneSubscription.php
134

I'll type some words here

151

This doesn't exist yet, but will in the future.

epriestley updated this revision to Diff 27856.Jan 30 2015, 4:37 PM
  • Type some words there.
btrahan accepted this revision.Jan 30 2015, 7:09 PM
btrahan edited edge metadata.

Some LiskDAO magic is likely confusing me.

src/applications/phortune/storage/PhortuneSubscription.php
139–146

I figured the $this->setPHID() bit would be in the parent::save() ?

This revision is now accepted and ready to land.Jan 30 2015, 7:09 PM
epriestley added inline comments.Jan 30 2015, 7:10 PM
src/applications/phortune/storage/PhortuneSubscription.php
139–146

Ah, yeah, this doesn't make sense anymore. It got juggled around a bit. I'll fix it, thanks!

epriestley updated this revision to Diff 27865.Jan 30 2015, 7:28 PM
epriestley edited edge metadata.
  • Remove now-redundant explicit generation of subscription PHID.
Closed by commit rP4adc2d8a72fc: Make it possible for applications to generate concrete subscriptions (authored by epriestley, committed by epriestley). · Explain WhyJan 30 2015, 7:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phortune/
controller/
3 lines
query/
9 lines
1 line
storage/
90 lines

Diff 27865

View Options

src/applications/phortune/controller/PhortuneAccountViewController.php

Loading...
View Options

src/applications/phortune/query/PhortuneSubscriptionQuery.php

Loading...
View Options

src/applications/phortune/query/PhortuneSubscriptionSearchEngine.php

Loading...
View Options

src/applications/phortune/storage/PhortuneSubscription.php

Loading...
Phabricator · Built by Phacility