Page MenuHomePhabricator

Projects - stop automagically associating projects when they are mentioned
ClosedPublic

Authored by btrahan on Jan 29 2015, 10:51 PM.
Tags
None
Referenced Files
F13997732: D11573.id27849.diff
Thu, Oct 24, 5:54 AM
F13997672: D11573.id.diff
Thu, Oct 24, 5:36 AM
F13997541: D11573.id.diff
Thu, Oct 24, 5:00 AM
F13990163: D11573.id27850.diff
Tue, Oct 22, 1:42 AM
F13989863: D11573.id27850.diff
Mon, Oct 21, 11:32 PM
F13988697: D11573.diff
Mon, Oct 21, 3:21 PM
F13983971: D11573.diff
Oct 20 2024, 10:01 AM
F13983893: D11573.diff
Oct 20 2024, 9:30 AM
Subscribers
Tokens
"Doubloon" token, awarded by chad.

Details

Summary

Fixes T6819. This isn't as useful as you might think and has one horribly buggy behavior - if you edit an object which has a description and a projects field, you can be unable to remove the associated project as the automagic association from the description kicks in. Further, since we've added the ability for applications to create multiple email addresses AND herald can react to those emails - say by programmatically adding projects - the known needs for this feature are basically 0. If this proves to be false we can maybe add some other syntax for these mentions - see T6819 for ideas / discussion.

Test Plan

removed a project from a maniphest task while still mentioning it in the description and it worked!

Diff Detail

Repository
rP Phabricator
Branch
T6819
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4175
Build 4188: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Projects - stop automagically associating projects when they are mentioned.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
This revision is now accepted and ready to land.Jan 29 2015, 10:53 PM
This revision was automatically updated to reflect the committed changes.