Page MenuHomePhabricator
Differential D11571

Application Emails - conditionally pass around the application email
ClosedPublic
Actions

Authored by btrahan on Jan 29 2015, 10:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 7:48 PM
Unknown Object (File)
Fri, Jan 24, 9:28 AM
Unknown Object (File)
Thu, Jan 23, 11:06 PM
Unknown Object (File)
Thu, Jan 23, 11:06 PM
Unknown Object (File)
Thu, Jan 23, 11:06 PM
Unknown Object (File)
Thu, Jan 23, 11:06 PM
Unknown Object (File)
Tue, Jan 21, 4:05 PM
Unknown Object (File)
Fri, Jan 3, 12:31 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7087: Getting errors saving Phriction Documents
T5039: Allow custom email addresses to file tickets against a project
Commits
Restricted Diffusion Commit
rP1077e7a80c44: Application Emails - conditionally pass around the application email
Summary

due to typehints, passing null is going to barf here. Ref D11564, ref T5039.

Test Plan

made an edit to a task from the web ui and it didnt fatal

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 27841.Jan 29 2015, 10:33 PM
btrahan retitled this revision from to Application Emails - conditionally pass around the application email.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan added a task: T5039: Allow custom email addresses to file tickets against a project.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 29 2015, 10:34 PM
epriestley accepted this revision.Jan 29 2015, 10:34 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 29 2015, 10:34 PM
Closed by commit rP1077e7a80c44: Application Emails - conditionally pass around the application email (authored by btrahan, committed by btrahan). · Explain WhyJan 29 2015, 10:35 PM
This revision was automatically updated to reflect the committed changes.
btrahan added a task: T7087: Getting errors saving Phriction Documents.Jan 29 2015, 10:41 PM

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
mail/
4 lines
8 lines
transactions/
editor/
4 lines

Diff 27842

View Options

src/applications/maniphest/mail/ManiphestCreateMailReceiver.php

Loading...
View Options

src/applications/maniphest/mail/ManiphestReplyHandler.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility