Page MenuHomePhabricator

Minor tidying of `ArcanistUpgradeWorkflow`
ClosedPublic

Authored by joshuaspence on Jan 29 2015, 11:42 AM.
Tags
None
Referenced Files
F14076515: D11554.diff
Thu, Nov 21, 5:49 PM
Unknown Object (File)
Thu, Nov 14, 5:16 AM
Unknown Object (File)
Thu, Nov 14, 5:05 AM
Unknown Object (File)
Tue, Nov 12, 12:10 AM
Unknown Object (File)
Oct 22 2024, 4:41 PM
Unknown Object (File)
Oct 21 2024, 9:37 PM
Unknown Object (File)
Oct 18 2024, 2:10 PM
Unknown Object (File)
Oct 16 2024, 8:28 PM
Subscribers

Details

Summary

Self-explanatory.

Test Plan

Eyeball it.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Minor tidying of `ArcanistUpgradeWorkflow`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/workflow/ArcanistUpgradeWorkflow.php
43–51

This is probably untranslatable even in English, since we would use "a git working copy" but "an svn working copy" and "an hg working copy" (at least, the way I pronounce them). The VCS type constants also aren't very human readable.

Consider restoring the "git" hardcode for now, or the "right" version of this is probably:

switch ($vcs_type) {
  pht('blah blah full string for git');
  pht('blah blah full string for svn');
  pht('blah blah full string for hg');
}
This revision is now accepted and ready to land.Jan 29 2015, 10:39 PM
This revision was automatically updated to reflect the committed changes.