Page MenuHomePhabricator

Application Emails - add datasource so we can have a typeahead

Authored by btrahan on Jan 28 2015, 10:10 PM.
Referenced Files
F13244122: D11546.diff
Thu, May 23, 4:33 AM
F13224832: D11546.id27796.diff
Sun, May 19, 11:18 AM
F13222556: D11546.diff
Sun, May 19, 3:45 AM
Sat, May 18, 7:56 AM
F13205234: D11546.diff
Wed, May 15, 1:36 AM
F13199069: D11546.id27796.diff
Mon, May 13, 11:23 AM
F13199068: D11546.id27795.diff
Mon, May 13, 11:22 AM
Mon, May 13, 11:01 AM



Ref T5039. This will be necessary for Herald integration so users can make rules like "if app email is one of x, y, or z add projects foo, bar, and metallica." I think its best to do an actual typeahead here -- users select full email addresses -- rather than support prefix, suffix, etc stuff on the email address. I think the latter approach would yield lots of confusion, as well as prevent us from (more) easily providing diagnostic tools about what happened when and why.

Test Plan

hacked a maniphest tokenizer to use this new datasource and it worked

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Application Emails - add datasource so we can have a typeahead.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Ah, yeah, this is probably a better approach.

One maybe-weird thing is that editing an email will affect rules, but that's probably reasonable/expected.

This revision is now accepted and ready to land.Jan 28 2015, 10:14 PM
This revision was automatically updated to reflect the committed changes.