Page MenuHomePhabricator

Make grammar more consistent
ClosedPublic

Authored by epriestley on Jan 28 2015, 8:51 PM.
Tags
None
Referenced Files
F14064919: D11544.diff
Tue, Nov 19, 1:54 AM
F14056072: D11544.id27785.diff
Sat, Nov 16, 6:10 PM
F14013759: D11544.id27786.diff
Sat, Nov 2, 12:14 PM
F14013758: D11544.id.diff
Sat, Nov 2, 12:14 PM
F14013081: D11544.id27785.diff
Sat, Nov 2, 12:32 AM
F14011938: D11544.diff
Fri, Nov 1, 6:12 AM
F13990516: D11544.diff
Tue, Oct 22, 4:08 AM
F13990505: D11544.diff
Tue, Oct 22, 4:02 AM
Subscribers

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rP6a0fb7c37f3f: Make grammar more consistent
Summary

In Maniphest, we say "X closed <task> by committing <commit>". In Differential, we currently say "X closed <revision> by commit <commit>", which sounds nongrammatical to me.

Test Plan

grammar'd

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make grammar more consistent.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 28 2015, 8:52 PM
This revision was automatically updated to reflect the committed changes.