Page MenuHomePhabricator

Fix anchor-clicking scroll positions
ClosedPublic

Authored by epriestley on Jan 28 2015, 3:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 4:05 AM
Unknown Object (File)
Sun, Nov 10, 7:55 AM
Unknown Object (File)
Sat, Nov 2, 9:51 AM
Unknown Object (File)
Sat, Nov 2, 9:51 AM
Unknown Object (File)
Sat, Nov 2, 9:51 AM
Unknown Object (File)
Fri, Nov 1, 7:47 AM
Unknown Object (File)
Fri, Nov 1, 4:29 AM
Unknown Object (File)
Thu, Oct 31, 4:01 PM
Subscribers

Details

Summary

Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong.

Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff.

Test Plan
  • Clicked comment anchors.
  • Loaded pages with anchors in the URI.
  • Loaded pages with anchors hidden behind "show older comments".

In all cases, got the right scroll position.

Diff Detail

Repository
rP Phabricator
Branch
scx1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4117
Build 4130: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix anchor-clicking scroll positions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 28 2015, 3:27 PM
This revision was automatically updated to reflect the committed changes.