Page MenuHomePhabricator

Check to make sure credential is not null in SSH command interface
ClosedPublic

Authored by hach-que on Jan 28 2015, 1:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 24, 6:10 PM
Unknown Object (File)
Sat, Feb 24, 4:32 PM
Unknown Object (File)
Thu, Feb 15, 10:38 PM
Unknown Object (File)
Thu, Feb 15, 10:37 PM
Unknown Object (File)
Thu, Feb 15, 10:35 PM
Unknown Object (File)
Jan 28 2024, 1:05 AM
Unknown Object (File)
Dec 31 2023, 2:31 PM
Unknown Object (File)
Dec 21 2023, 7:17 AM
Subscribers

Details

Summary

This adds a check to make sure the credential exists when loading it in the Drydock SSH interface. This effectively turns a fatal error (calling a method on a non-object) into a catchable exception.

Test Plan

Had a badly configured resource, saw the exception appear instead of daemon fataling.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hach-que retitled this revision from to Check to make sure credential is not null in SSH command interface.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 28 2015, 7:12 PM
This revision was automatically updated to reflect the committed changes.