Page MenuHomePhabricator

Fix failing unit tests for `ArcanistLesscLinter`
ClosedPublic

Authored by joshuaspence on Jan 27 2015, 11:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 8:48 AM
Unknown Object (File)
Oct 19 2024, 4:21 PM
Unknown Object (File)
Oct 19 2024, 6:39 AM
Unknown Object (File)
Oct 17 2024, 8:29 PM
Unknown Object (File)
Sep 26 2024, 5:59 PM
Unknown Object (File)
Sep 5 2024, 2:44 PM
Unknown Object (File)
Sep 3 2024, 9:45 AM
Unknown Object (File)
Sep 1 2024, 3:45 AM
Subscribers

Details

Summary

A bunch of unit tests are failing with the latest version of lessc (v2.3.0). I decided to delete a bunch of test cases for this linter as we have far too many at the moment.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Fix failing unit tests for `ArcanistLesscLinter`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Cool, I think this is desirable/correct. As elsewhere, we don't really benefit from covering the nuances in behavior of external linters, and primarily care that the binding works -- and we don't need 300 tests to establish that.

This revision is now accepted and ready to land.Jan 27 2015, 2:25 PM
This revision was automatically updated to reflect the committed changes.