Page MenuHomePhabricator

Add configuration option for PHPUnit test dirs
Needs RevisionPublic

Authored by sascha-egerer on Jan 27 2015, 7:35 AM.
Referenced Files
F13034253: D11515.id27696.diff
Sat, Apr 13, 11:37 AM
F13034252: D11515.id27694.diff
Sat, Apr 13, 11:37 AM
Sat, Apr 13, 11:01 AM
F13034004: D11515.diff
Sat, Apr 13, 9:42 AM
Unknown Object (File)
Thu, Apr 11, 7:10 AM
Unknown Object (File)
Thu, Apr 11, 3:37 AM
Unknown Object (File)
Sun, Apr 7, 8:58 PM
Unknown Object (File)
Mon, Apr 1, 10:08 AM



The PHPUnit testengine expects that the unit tests are located
in a folder tests or Tests. In some setups this does not fit because tests
could also be located on different places. For example they could be stored
in a folter "tests/Unit/". Therefore there should be a configuration option
for the PHPUnit tests folders instead of setting them to a fixed value.

Test Plan

Run arc unit --coverage in a setup where the unit test for the class
src/foo.php is stored in the folder tests/Unit/foo.php. There should be no
coverage report. Now add the configuration option to the .arcconfig

  "phpunit_test_dirs" : [ "tests/Unit" ]

and run arc unit --coverage again.

Diff Detail

rARC Arcanist
Lint Passed
Tests Passed
Build Status
Buildable 4075
Build 4088: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

sascha-egerer retitled this revision from to Add configuration option for PHPUnit test dirs.
sascha-egerer updated this object.
sascha-egerer edited the test plan for this revision. (Show Details)
sascha-egerer edited edge metadata.

Removed some whitespace changes

That does also fix the problem that unit tests are not executed when doing an arc diff if they are not stored directly in the tests folder.

epriestley added a reviewer: epriestley.

This should wait for T5568 and rebuild on top of that.

Particularly, I do not want to add global configuration for a specific test engine.

This revision now requires changes to proceed.May 19 2015, 2:46 PM