Page MenuHomePhabricator
Differential D11505

Fix call to scrollToPosition()
ClosedPublic
Actions

Authored by epriestley on Jan 26 2015, 1:52 PM.
Tags
None
Referenced Files
F14123437: D11505.id27665.diff
Fri, Nov 29, 10:11 PM
Unknown Object (File)
Wed, Nov 27, 1:29 PM
Unknown Object (File)
Tue, Nov 19, 5:55 AM
Unknown Object (File)
Oct 26 2024, 11:10 AM
Unknown Object (File)
Oct 22 2024, 1:31 AM
Unknown Object (File)
Oct 20 2024, 11:41 PM
Unknown Object (File)
Oct 17 2024, 10:01 AM
Unknown Object (File)
Oct 11 2024, 1:15 PM
View All Files
Subscribers
epriestley
krzysztof.ciebiera

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rP62cb898408ae: Fix call to scrollToPosition()
Summary

See rPea67a8ab8e58. This was typed wrong and all the things I tested called scrollToPosition() directly.

Test Plan

Quoted a comment.

Diff Detail

Repository
rP Phabricator
Branch
quote1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4054
Build 4067: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27665.Jan 26 2015, 1:52 PM
epriestley retitled this revision from to Fix call to scrollToPosition().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a subscriber: krzysztof.ciebiera.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 26 2015, 1:52 PM
chad accepted this revision.Jan 26 2015, 4:31 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 26 2015, 4:31 PM
Closed by commit rP62cb898408ae: Fix call to scrollToPosition() (authored by epriestley, committed by epriestley). · Explain WhyJan 26 2015, 5:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
webroot/
rsrc/
externals/
javelin/
lib/
2 lines

Diff 27665

View Options

webroot/rsrc/externals/javelin/lib/DOM.js

Loading...
Phabricator · Built by Phacility