Page MenuHomePhabricator
Differential D11499

Roll out more FontIcons
ClosedPublic
Actions

Authored by chad on Jan 26 2015, 2:36 AM.
Tags
None
Referenced Files
F14092464: D11499.diff
Mon, Nov 25, 6:16 AM
Unknown Object (File)
Thu, Nov 21, 7:24 AM
Unknown Object (File)
Sun, Nov 17, 8:10 AM
Unknown Object (File)
Oct 24 2024, 2:17 PM
Unknown Object (File)
Oct 22 2024, 7:13 PM
Unknown Object (File)
Oct 22 2024, 11:17 AM
Unknown Object (File)
Oct 22 2024, 11:10 AM
Unknown Object (File)
Oct 22 2024, 11:09 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Love" token, awarded by johnny-bit.

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP96edc9d2bc8f: Roll out more FontIcons
Summary

Sidenav launcher, search typeahead results, apps launcher

Test Plan

Used each of these items

pasted_file (735×223 px, 101 KB)

Diff Detail

Repository
rP Phabricator
Branch
font-app-icons-v2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4047
Build 4060: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 27657.Jan 26 2015, 2:36 AM
chad retitled this revision from to Roll out more FontIcons.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 26 2015, 2:36 AM
chad edited the test plan for this revision. (Show Details)Jan 26 2015, 2:38 AM
chad added inline comments.
src/applications/diffusion/application/PhabricatorDiffusionApplication.php
22

Went back to code here. The silhouette is much easier to pick out than the file code icon, and it's very easy to spot in the sidebar now.

chad updated this revision to Diff 27658.Jan 26 2015, 3:27 AM
  • Remove remaining use of apps-sprite-large
johnny-bit awarded a token.Jan 26 2015, 7:39 AM
epriestley accepted this revision.Jan 26 2015, 3:18 PM
epriestley edited edge metadata.

Cool. In practice, I think these work a lot better than I'd expected they might.

This revision is now accepted and ready to land.Jan 26 2015, 3:18 PM
Closed by commit rP96edc9d2bc8f: Roll out more FontIcons (authored by chad, committed by chad). · Explain WhyJan 26 2015, 4:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27658

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

resources/sprite/manifest/apps-large.json

Loading...
View Options

resources/sprite/manifest/apps-xlarge.json

Loading...
View Options

src/applications/base/controller/PhabricatorController.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/diviner/application/PhabricatorDivinerApplication.php

Loading...
View Options

src/applications/macro/application/PhabricatorMacroApplication.php

Loading...
View Options

src/applications/meta/query/PhabricatorAppSearchEngine.php

Loading...
View Options

src/applications/meta/typeahead/PhabricatorApplicationDatasource.php

Loading...
View Options

src/applications/meta/view/PhabricatorApplicationLaunchView.php

Loading...
View Options

src/applications/settings/panel/PhabricatorHomePreferencesSettingsPanel.php

Loading...
View Options

src/view/phui/PHUICrumbView.php

Loading...
View Options

webroot/rsrc/css/application/base/main-menu-view.css

Loading...
View Options

webroot/rsrc/css/application/base/phabricator-application-launch-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-crumbs-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-icon.css

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
View Options

webroot/rsrc/css/sprite-apps-large.css

Loading...
View Options

webroot/rsrc/image/sprite-apps-large-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-apps-large.png

Loading...
Phabricator · Built by Phacility