Proxy VCS HTTP requests
ClosedPublic
Actions

Authored by epriestley on Jan 25 2015, 4:42 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7019: Proxy HTTP VCS traffic

Commits

Restricted Diffusion Commit
rPfb5e50e6cc1f: Proxy VCS HTTP requests

Summary

Ref T7019. When we receive a git clone https:// (or git push on HTTP/S), and the repository is not local, proxy the request to the appropriate service.

This has scalability limits, but they are not more severe than the existing limits (T4369) and are about as abstracted as we can get them.

This doesn't fully work in a Phacility context because the commit hook does not know which instance it is running in, but that problem is not unique to HTTP.

Test Plan

Pushed and pulled a Git repo via proxy.
Pulled a Git repo normally.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 27646.Jan 25 2015, 4:42 PM

epriestley retitled this revision from to Proxy VCS HTTP requests.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7019: Proxy HTTP VCS traffic.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 25 2015, 4:42 PM

(To make this testable and less surprising, this follows the same proxying rules that the Conduit stuff does: if a repo is on a service, we always proxy, even if the service is locally.)

btrahan accepted this revision.Jan 27 2015, 10:22 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jan 27 2015, 10:22 PM

Closed by commit rPfb5e50e6cc1f: Proxy VCS HTTP requests (authored by epriestley, committed by epriestley). · Explain WhyJan 27 2015, 10:51 PM

This revision was automatically updated to reflect the committed changes.