Page MenuHomePhabricator
Differential D11484

Allow scrollbars to be dragged outside the window on supporting browsers
ClosedPublic
Actions

Authored by epriestley on Jan 24 2015, 10:11 PM.
Tags
None
Referenced Files
F14815260: D11484.diff
Mon, Jan 27, 7:39 PM
Unknown Object (File)
Thu, Jan 23, 10:36 PM
Unknown Object (File)
Thu, Jan 23, 10:36 PM
Unknown Object (File)
Thu, Jan 23, 10:36 PM
Unknown Object (File)
Thu, Jan 23, 10:36 PM
Unknown Object (File)
Thu, Jan 23, 6:08 PM
Unknown Object (File)
Tue, Jan 21, 1:02 PM
Unknown Object (File)
Tue, Jan 21, 9:53 AM
View All Files
Subscribers
epriestley
johnny-bit

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rP4ceaaf5ea1ab: Allow scrollbars to be dragged outside the window on supporting browsers
Summary

In Safari, Firefox and Chrome drags outside the window will work if we do this. Safari didn't work before, not sure about the other two.

Test Plan

Clicked the scroll handle, then dragged my mouse to the right (outside the window) and down. Page scrolled in Safari, Firefox, and Chrome.

Diff Detail

Repository
rP Phabricator
Branch
scrollx2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4024
Build 4037: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27626.Jan 24 2015, 10:11 PM
epriestley retitled this revision from to Allow scrollbars to be dragged outside the window on supporting browsers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 24 2015, 10:11 PM
chad accepted this revision.Jan 24 2015, 10:18 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 24 2015, 10:18 PM
Closed by commit rP4ceaaf5ea1ab: Allow scrollbars to be dragged outside the window on supporting browsers (authored by epriestley, committed by epriestley). · Explain WhyJan 24 2015, 10:18 PM
This revision was automatically updated to reflect the committed changes.
johnny-bit added a subscriber: johnny-bit.Jan 25 2015, 12:19 AM

Hey, I don't know if this in paricular causes this behaviur but I guess it will be hard to fix, so - might as well be here...

Follow test plan: Clicked the scroll handle, then dragged my mouse to the right (outside the window) and down. Page scrolled in Safari, Firefox, and Chrome. Release mouse button while outside window. Page does not scroll while moving mouse outside of browser. Move pointer inside browser window - page scrolls with mouse despite no click nor drag. Behaviour seen here, and on freshly updated server.

epriestley added a comment.Jan 25 2015, 12:30 AM

Thanks, D11487 should fix that (and one more thing I caught).

Revision Contents
Changeset List

PathSize
resources/
celerity/
16 lines
webroot/
rsrc/
externals/
javelin/
lib/
6 lines

Diff 27626

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/externals/javelin/lib/Scrollbar.js

Loading...
Phabricator · Built by Phacility