Page MenuHomePhabricator

Allow `arc unit --everything` to work without a base commit
ClosedPublic

Authored by joshuaspence on Jan 21 2015, 9:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 14, 10:10 PM
Unknown Object (File)
Mon, Feb 5, 7:32 PM
Unknown Object (File)
Jan 26 2024, 6:02 PM
Unknown Object (File)
Dec 25 2023, 8:31 PM
Unknown Object (File)
Dec 20 2023, 8:27 AM
Unknown Object (File)
Dec 15 2023, 6:45 AM
Unknown Object (File)
Dec 10 2023, 1:47 PM
Unknown Object (File)
Nov 30 2023, 4:36 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
Restricted Maniphest Task
Commits
rARC0b22838ccaa8: Allow `arc unit --everything` to work without a base commit
Summary

Fixes T2461. Similarly to arc lint --everything, arc unit --everything should work without a base commit.

Test Plan

Removed the .git/arc/default-relative-commit file and ran arc unit --everything.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Allow `arc unit --everything` to work without a base commit.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: Restricted Maniphest Task.
epriestley edited edge metadata.

This feels a little wasteful since engines may be able to avoid doing this work (e.g., Phutil engines can enumerate tests without scanning the disk for files) but we can deal with that when we, e.g., adjust APIs for .arcunit or whatever.

This revision is now accepted and ready to land.Jan 22 2015, 8:20 PM
This revision was automatically updated to reflect the committed changes.