When storage is not initialized, write the error message to stderr instead of stdout
ClosedPublic
Actions

Authored by epriestley on Jan 20 2015, 10:02 PM.

Details

Reviewers

Commits

Restricted Diffusion Commit
rPe90695fc8332: When storage is not initialized, write the error message to stderr instead of…

Summary

We have to do some garbage nonsense to write database backups right now, see T6996.

When storage isn't initialized, we previously ended up with this message gzipped in a file and an empty error. Make the behavior slightly more tolerable.

Test Plan

Saw a meaningful error after trying to back up an uninitialized database.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 27522.Jan 20 2015, 10:02 PM

epriestley retitled this revision from to When storage is not initialized, write the error message to stderr instead of stdout.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 20 2015, 10:02 PM

btrahan accepted this revision.Jan 20 2015, 10:04 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jan 20 2015, 10:04 PM

Closed by commit rPe90695fc8332: When storage is not initialized, write the error message to stderr instead of… (authored by epriestley, committed by epriestley). · Explain WhyJan 20 2015, 10:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

storage/

management/

workflow/

PhabricatorStorageManagementDumpWorkflow.php

12 lines

Diff 27524

View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php

When storage is not initialized, write the error message to stderr instead of stdoutClosedPublicActions