Differential D11447

Fix validation of network names in Almanac
ClosedPublic
Actions

Authored by epriestley on Jan 20 2015, 9:34 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T5833: Build "Almanac", a service/host/device directory

Commits

Restricted Diffusion Commit
rP20dbdd7c28d6: Fix validation of network names in Almanac

Summary

Ref T5833. This was using the wrong constant, so we weren't validating property.

Test Plan

Tried to create a nameless network and correctly got an error.

Diff Detail

Repository

rP Phabricator

Branch

need1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3948
Build 3961: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27519.Jan 20 2015, 9:34 PM

epriestley retitled this revision from to Fix validation of network names in Almanac.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5833: Build "Almanac", a service/host/device directory.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 20 2015, 9:34 PM

btrahan accepted this revision.Jan 20 2015, 9:40 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jan 20 2015, 9:40 PM

Closed by commit rP20dbdd7c28d6: Fix validation of network names in Almanac (authored by epriestley, committed by epriestley). · Explain WhyJan 20 2015, 10:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

editor/

AlmanacNetworkEditor.php

2 lines

Diff 27519

View Options

src/applications/almanac/editor/AlmanacNetworkEditor.php

Fix validation of network names in AlmanacClosedPublicActions