Paths

Table of Contentst

Differential D11439

Enable the `freeze` option for JSHint
ClosedPublic
Actions

Authored by joshuaspence on Jan 20 2015, 7:40 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP8113e6d8c1a3: Enable the `freeze` option for JSHint

Summary

This option prohibits overwriting prototypes of native objects such as Array, Date and so on.

// jshint freeze:true
Array.prototype.count = function (value) { return 4; };
// -> Warning: Extending prototype of native object: 'Array'.

Test Plan

Linted existing JavaScript files, found no violations.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27489.Jan 20 2015, 7:40 AM

joshuaspence retitled this revision from to Enable the `freeze` option for JSHint.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 20 2015, 7:40 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 20 2015, 9:20 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 20 2015, 9:20 AM

Closed by commit rP8113e6d8c1a3: Enable the `freeze` option for JSHint (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 20 2015, 10:25 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

support/

lint/

browser.jshintrc

1 line

node.jshintrc

1 line

Diff 27495

View Options

support/lint/browser.jshintrc