Differential D11427

Add a "daily routine" trigger clock for backups, etc.
ClosedPublic
Actions

Authored by epriestley on Jan 19 2015, 3:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 17, 7:41 AM

	Unknown Object (File)
	Fri, Sep 13, 2:59 PM

	Unknown Object (File)
	Fri, Sep 13, 2:58 PM

	Unknown Object (File)
	Fri, Sep 13, 2:57 PM

	Unknown Object (File)
	Fri, Sep 13, 2:57 PM

	Unknown Object (File)
	Fri, Sep 13, 2:57 PM

	Unknown Object (File)
	Tue, Sep 10, 2:12 AM

	Unknown Object (File)
	Sun, Sep 1, 2:38 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune

Commits

Restricted Diffusion Commit
rPa988a1a04354: Add a "daily routine" trigger clock for backups, etc.

Summary

Ref T6881. Before implementing subscriptions, I'm going to vet triggers by using them to do backups. Each instance will get a daily trigger for backups, and that should give us a smaller-scale test to catch issues and limitations, with more opportunities for something to go wrong since it fires more often.

Test Plan

Added unit tests.

Diff Detail

Repository

Branch

trigger1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3905
Build 3917: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27453.Jan 19 2015, 3:45 PM

epriestley retitled this revision from to Add a "daily routine" trigger clock for backups, etc..

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 19 2015, 3:45 PM

Move a comment one line away.

btrahan accepted this revision.Jan 19 2015, 9:48 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jan 19 2015, 9:48 PM

Closed by commit rPa988a1a04354: Add a "daily routine" trigger clock for backups, etc. (authored by epriestley, committed by epriestley). · Explain WhyJan 20 2015, 12:54 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

infrastructure/

daemon/

workers/

clock/

PhabricatorDailyRoutineTriggerClock.php

57 lines

__tests__/

PhabricatorTriggerClockTestCase.php

100 lines

Diff 27454

src/__phutil_library_map__.php

Loading...

src/infrastructure/daemon/workers/clock/PhabricatorDailyRoutineTriggerClock.php

Loading...

src/infrastructure/daemon/workers/clock/tests/PhabricatorTriggerClockTestCase.php

Loading...