Project revamp part 2: Edit
ClosedPublic
Actions

Authored by chad on Jan 17 2015, 7:34 PM.

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rP3bc54c2041be: Project revamp part 2: Edit

Summary

Taking a pass at revamping the edit pages in Projects. Specifically:

Remove EditMainController
Move actions from EditMain to Profile
Move properties from EditMain to Profile
Move timeline from EditMain to Profile
Move Open Tasks from Profile to sidenavicon
Add custom icons and colors to timeline

Feel free to bang on this a bit and give feedback, feels generally correct to me.

Test Plan

Edit everything I could on various projects. Check links, timelines, actions.

Diff Detail

Repository

rP Phabricator

Branch

project-edit-revamp

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3908
Build 3920: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 27438.Jan 17 2015, 7:34 PM

chad retitled this revision from to Project revamp part 2: Edit.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 17 2015, 7:34 PM

This generally feels good to me.
Having "Edit Details" be a separate tab feels weird to me now, especially because it's the last tab. Maybe de-tab it? But then maybe it needs crumbs, which is a step away from the direction here...

src/applications/project/controller/PhabricatorProjectController.php
72	I think this is an improvement, although I wonder if, e.g., just putting a button on the workboard would be even better? If Maniphest isn't installed, we shouldn't show this tab.
src/applications/project/controller/PhabricatorProjectProfileController.php
35–36	This thing seems really out of place to me now, especially given that tasks can be created from the workboard.
213–215	We can remove this, since it's in the header.
217–219	For consistency, we could remove this: you can generally figure it out by clicking "edit" (either you can see the policy from there, or you'll get an error telling you why you can't edit, thus implying who can).

This revision is now accepted and ready to land.Jan 19 2015, 5:50 PM

On the edit tab... I can't think of another solution. I want to keep edit a click away regardless of if you auto-landed on workboard or on details. I'd like to keep it for a bit to see if my patterns change. It also feels strange to have the IconNav on the side, but no 'active' icon.