Page MenuHomePhabricator

Project revamp part 2: Edit
ClosedPublic

Authored by chad on Jan 17 2015, 7:34 PM.
Tags
None
Referenced Files
F13213524: D11421.diff
Fri, May 17, 7:51 AM
Unknown Object (File)
Tue, May 7, 7:24 AM
Unknown Object (File)
Fri, May 3, 6:09 AM
Unknown Object (File)
Thu, Apr 25, 1:01 AM
Unknown Object (File)
Apr 7 2024, 4:11 AM
Unknown Object (File)
Apr 6 2024, 5:28 AM
Unknown Object (File)
Mar 15 2024, 8:36 AM
Unknown Object (File)
Feb 14 2024, 6:30 AM
Subscribers

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP3bc54c2041be: Project revamp part 2: Edit
Summary

Taking a pass at revamping the edit pages in Projects. Specifically:

  • Remove EditMainController
  • Move actions from EditMain to Profile
  • Move properties from EditMain to Profile
  • Move timeline from EditMain to Profile
  • Move Open Tasks from Profile to sidenavicon
  • Add custom icons and colors to timeline

Feel free to bang on this a bit and give feedback, feels generally correct to me.

Test Plan

Edit everything I could on various projects. Check links, timelines, actions.

Diff Detail

Repository
rP Phabricator
Branch
project-edit-revamp
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3908
Build 3920: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to Project revamp part 2: Edit.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.
  • This generally feels good to me.
  • Having "Edit Details" be a separate tab feels weird to me now, especially because it's the last tab. Maybe de-tab it? But then maybe it needs crumbs, which is a step away from the direction here...
src/applications/project/controller/PhabricatorProjectController.php
72

I think this is an improvement, although I wonder if, e.g., just putting a button on the workboard would be even better?

If Maniphest isn't installed, we shouldn't show this tab.

src/applications/project/controller/PhabricatorProjectProfileController.php
35–36

This thing seems really out of place to me now, especially given that tasks can be created from the workboard.

213–215

We can remove this, since it's in the header.

217–219

For consistency, we could remove this: you can generally figure it out by clicking "edit" (either you can see the policy from there, or you'll get an error telling you why you can't edit, thus implying who can).

This revision is now accepted and ready to land.Jan 19 2015, 5:50 PM

On the edit tab... I can't think of another solution. I want to keep edit a click away regardless of if you auto-landed on workboard or on details. I'd like to keep it for a bit to see if my patterns change. It also feels strange to have the IconNav on the side, but no 'active' icon.

src/applications/project/controller/PhabricatorProjectProfileController.php
35–36

I'll remove it.

chad edited edge metadata.
  • Limit 'tasks' tab to Maniphest Installed
  • Remove 'new task' button
  • Remove duplicate project properties
This revision was automatically updated to reflect the committed changes.