Fix mobile action menus in Phriction
ClosedPublic
Actions

Authored by chad on Jan 17 2015, 4:54 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T6963: Phriction action menu doesn't display on mobile

Commits

Restricted Diffusion Commit
rP00faa2b2f7b5: Fix mobile action menus in Phriction

Summary

Fixes T6963. Long term will likely make this more like other document views, but not worth the time right now since this is only location.

Test Plan

Review Phriction document at desktop and mobile breakpoints. Click menu and see menu.

Diff Detail

Repository

rP Phabricator

Branch

document-action-mobile

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3889
Build 3901: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 27437.Jan 17 2015, 4:54 PM

chad retitled this revision from to Fix mobile action menus in Phriction.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T6963: Phriction action menu doesn't display on mobile.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 17 2015, 4:54 PM

epriestley accepted this revision.Jan 19 2015, 6:11 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 19 2015, 6:11 PM

Closed by commit rP00faa2b2f7b5: Fix mobile action menus in Phriction (authored by chad, committed by chad). · Explain WhyJan 19 2015, 8:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

controller/

PhrictionDocumentController.php

3 lines

view/

phui/

PHUIDocumentView.php

27 lines

Diff 27437

View Options

src/applications/phriction/controller/PhrictionDocumentController.php