Only test symbols from the current library
ClosedPublic
Actions

Authored by joshuaspence on Jan 15 2015, 9:15 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU00f1fcdc19e0: Only test symbols from the current library

Summary

Limit the acceptance testing surrounding symbols to only consider symbols from the current library. See D11052#107199.

Test Plan

Increased the method visibility of a class in rARC and ran arc lint -- src/ in rP.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27424.Jan 15 2015, 9:15 PM

joshuaspence retitled this revision from to Only test symbols from the current library.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 15 2015, 9:15 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 15 2015, 9:15 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 15 2015, 9:15 PM

Closed by commit rPHU00f1fcdc19e0: Only test symbols from the current library (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 15 2015, 9:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__tests__/

PhutilLibraryTestCase.php

12 lines

Diff 27425

View Options

src/tests/PhutilLibraryTestCase.php

Only test symbols from the current libraryClosedPublicActions