Page MenuHomePhabricator
Differential D11398

Minor tidying of Aphlict code
ClosedPublic
Actions

Authored by joshuaspence on Jan 14 2015, 9:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 28, 7:06 PM
Unknown Object (File)
Sat, Aug 24, 3:34 PM
Unknown Object (File)
Jul 31 2024, 7:39 AM
Unknown Object (File)
Jul 27 2024, 12:23 PM
Unknown Object (File)
Jul 26 2024, 9:24 PM
Unknown Object (File)
Jul 23 2024, 6:56 AM
Unknown Object (File)
Jul 19 2024, 7:30 PM
Unknown Object (File)
Jul 19 2024, 10:35 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Haypence" token, awarded by btrahan.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPf55647736a68: Minor tidying of Aphlict code
Summary

Just some housekeeping... mostly just removing some unused variables.

Test Plan

Checked that I was still about to receive notifications from /notification/status/.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27374.Jan 14 2015, 9:01 PM
joshuaspence retitled this revision from to Minor tidying of Aphlict code.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 14 2015, 9:01 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 14 2015, 9:04 PM
epriestley edited edge metadata.
epriestley added inline comments.
webroot/rsrc/js/application/aphlict/behavior-aphlict-status.js
31

both sigil and meta can be removed wholesale, I think

This revision is now accepted and ready to land.Jan 14 2015, 9:04 PM
Closed by commit rPf55647736a68: Minor tidying of Aphlict code (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 14 2015, 9:08 PM
This revision was automatically updated to reflect the committed changes.
btrahan awarded a token.Jan 14 2015, 9:10 PM
epriestley mentioned this in D11360: Multiplex AJAX calls.Jan 15 2015, 2:14 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
88 lines
webroot/
rsrc/
js/
application/
aphlict/
23 lines
4 lines
12 lines
10 lines

Diff 27375

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/aphlict/Aphlict.js

Loading...
View Options

webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js

Loading...
View Options

webroot/rsrc/js/application/aphlict/behavior-aphlict-listen.js

Loading...
View Options

webroot/rsrc/js/application/aphlict/behavior-aphlict-status.js

Loading...
Phabricator · Built by Phacility