Page MenuHomePhabricator
Differential D11395

Provide read and overwrite for Lisk counters
ClosedPublic
Actions

Authored by epriestley on Jan 14 2015, 7:24 PM.
Tags
None
Referenced Files
F14045316: D11395.diff
Wed, Nov 13, 2:49 AM
F14036961: D11395.diff
Sun, Nov 10, 1:08 PM
F14018637: D11395.diff
Tue, Nov 5, 5:25 PM
F13989284: D11395.id27372.diff
Mon, Oct 21, 7:29 PM
F13978919: D11395.id27363.diff
Sat, Oct 19, 1:39 AM
Unknown Object (File)
Oct 11 2024, 5:37 PM
Unknown Object (File)
Oct 1 2024, 10:05 PM
Unknown Object (File)
Sep 17 2024, 7:41 AM
View All Files
Subscribers
chad
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune
Commits
Restricted Diffusion Commit
rP7ab5d108a46f: Provide read and overwrite for Lisk counters
Summary

Ref T6881. This is part 1 of my 35-step plan to support subscriptions that bill monthly.

Expanding the capabilities of counters will let me use them to create a logical clock on time-based event updates, build a daemon on top of that, and eventually get time-based triggers.

Test Plan

Added and executed unit tests.

Diff Detail

Repository
rP Phabricator
Branch
trigger
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3847
Build 3859: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27363.Jan 14 2015, 7:24 PM
epriestley retitled this revision from to Provide read and overwrite for Lisk counters.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 14 2015, 7:24 PM
chad added a subscriber: chad.Jan 14 2015, 7:39 PM

35 steps... so 2-3 days?

btrahan edited edge metadata.Jan 14 2015, 7:40 PM

Prolly 2-3 hours spread out over 2-3 days... :D

btrahan accepted this revision.Jan 14 2015, 7:41 PM
btrahan edited edge metadata.

Nice.

This revision is now accepted and ready to land.Jan 14 2015, 7:41 PM
Closed by commit rP7ab5d108a46f: Provide read and overwrite for Lisk counters (authored by epriestley, committed by epriestley). · Explain WhyJan 14 2015, 8:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
storage/
lisk/
57 lines
__tests__/
27 lines

Diff 27363

View Options

src/infrastructure/storage/lisk/LiskDAO.php

Loading...
View Options

src/infrastructure/storage/lisk/__tests__/LiskFixtureTestCase.php

Loading...
Phabricator · Built by Phacility