Page MenuHomePhabricator

Allow daemons to be terminated in the absence of MySQL
ClosedPublic

Authored by joshuaspence on Jan 14 2015, 11:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 25, 9:02 AM
Unknown Object (File)
Apr 17 2025, 5:34 PM
Unknown Object (File)
Apr 3 2025, 5:09 PM
Unknown Object (File)
Mar 24 2025, 6:20 AM
Unknown Object (File)
Mar 24 2025, 4:04 AM
Unknown Object (File)
Mar 15 2025, 5:49 AM
Unknown Object (File)
Mar 14 2025, 8:30 PM
Unknown Object (File)
Mar 13 2025, 12:14 AM
Subscribers

Details

Summary

Fixes T6842. Allow the daemons to always be terminated, even if MySQL is down. I was hoping to be able to optionally enable this behavior with the --force flag, but this seems messy.

Test Plan
> ./bin/phd start
Freeing active task leases...
Freed 1 task lease(s).
Preparing to launch daemons.
NOTE: Logs will appear in '/var/tmp/phd/log/daemons.log'.

Starting daemons as phd
Launching daemon "PhabricatorRepositoryPullLocalDaemon".
Starting daemons as phd
Launching daemon "PhabricatorGarbageCollectorDaemon".
Starting daemons as phd
Launching daemon "PhabricatorTaskmasterDaemon".
Done.

> service mysql stop
mysql stop/waiting

> ./bin/phd stop
Interrupting daemon 'PhabricatorRepositoryPullLocalDaemon' (4263)...
Interrupting daemon 'PhabricatorGarbageCollectorDaemon' (4271)...
Interrupting daemon 'PhabricatorTaskmasterDaemon' (4287)...
Daemon 4263 exited.
Daemon 4271 exited.
Daemon 4287 exited.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Allow daemons to be terminated in the absence of MySQL.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 14 2015, 2:00 PM
This revision was automatically updated to reflect the committed changes.