Page MenuHomePhabricator
Differential D11378

OAuthServer - implement destructible interface on oauth server client objects
ClosedPublic
Actions

Authored by btrahan on Jan 14 2015, 12:02 AM.
Tags
None
Referenced Files
F13158900: D11378.diff
Sun, May 5, 10:13 PM
Unknown Object (File)
Fri, May 3, 6:16 AM
Unknown Object (File)
Thu, May 2, 2:32 AM
Unknown Object (File)
Mon, Apr 29, 3:20 PM
Unknown Object (File)
Mon, Apr 29, 6:20 AM
Unknown Object (File)
Thu, Apr 25, 7:04 PM
Unknown Object (File)
Thu, Apr 25, 7:03 PM
Unknown Object (File)
Wed, Apr 24, 11:45 PM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Haypence" token, awarded by epriestley.

Details

Reviewers
epriestley
Maniphest Tasks
T6955: Make PhabricatorOAuthServerClient implement PhabricatorDestructibleInterface
Commits
Restricted Diffusion Commit
rP4655b7e4da8e: OAuthServer - implement destructible interface on oauth server client objects
Summary

Fixes T6955.

Test Plan

made an oauth app. made a test authorization. ran bin/remove destroy <phid of oauth client> and there were no errors. verified oauth app and test authorization were both gone.

Diff Detail

Repository
rP Phabricator
Branch
T6955
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3827
Build 3839: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 27332.Jan 14 2015, 12:02 AM
btrahan added a task: T6955: Make PhabricatorOAuthServerClient implement PhabricatorDestructibleInterface.
btrahan retitled this revision from to OAuthServer - implement destructible interface on oauth server client objects.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 14 2015, 12:02 AM
epriestley accepted this revision.Jan 14 2015, 12:09 AM
epriestley edited edge metadata.

Does it make sense to nuke AccessToken and/or AuthorizationCode?

This revision is now accepted and ready to land.Jan 14 2015, 12:09 AM
btrahan updated this revision to Diff 27337.Jan 14 2015, 12:15 AM
btrahan edited edge metadata.

also delete access tokens and authorization codes

Closed by commit rP4655b7e4da8e: OAuthServer - implement destructible interface on oauth server client objects (authored by btrahan, committed by btrahan). · Explain WhyJan 14 2015, 12:17 AM
This revision was automatically updated to reflect the committed changes.
epriestley awarded a token.Jan 14 2015, 12:27 AM

Looks like it's working in Instances.

Revision Contents
Changeset List

PathSize
src/
applications/
oauthserver/
storage/
21 lines

Diff 27332

View Options

src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php

Loading...
Phabricator · Built by Phacility