OAuthServer - implement destructible interface on oauth server client objects
ClosedPublic
Actions

Authored by btrahan on Jan 14 2015, 12:02 AM.

Tags

None

Referenced Files

	F15547123: D11378.diff
	Sat, Apr 26, 6:17 PM

	F15541000: D11378.id.diff
	Fri, Apr 25, 10:07 AM

	F15531888: D11378.id27332.diff
	Wed, Apr 23, 1:38 PM

	F15530543: D11378.id27332.diff
	Wed, Apr 23, 5:02 AM

	F15529835: D11378.id27339.diff
	Tue, Apr 22, 10:50 PM

	F15527229: D11378.id27332.diff
	Tue, Apr 22, 2:01 AM

	F15520913: D11378.id27339.diff
	Sun, Apr 20, 9:13 AM

	F15520902: D11378.id.diff
	Sun, Apr 20, 9:04 AM

View All Files

Subscribers

epriestley

Korvin

Tokens

"Haypence" token, awarded by epriestley.

Details

Reviewers

epriestley

Maniphest Tasks

T6955: Make PhabricatorOAuthServerClient implement PhabricatorDestructibleInterface

Commits

Restricted Diffusion Commit
rP4655b7e4da8e: OAuthServer - implement destructible interface on oauth server client objects

Summary

Fixes T6955.

Test Plan

made an oauth app. made a test authorization. ran bin/remove destroy <phid of oauth client> and there were no errors. verified oauth app and test authorization were both gone.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 27332.Jan 14 2015, 12:02 AM

btrahan added a task: T6955: Make PhabricatorOAuthServerClient implement PhabricatorDestructibleInterface.

btrahan retitled this revision from to OAuthServer - implement destructible interface on oauth server client objects.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 14 2015, 12:02 AM

Does it make sense to nuke AccessToken and/or AuthorizationCode?

This revision is now accepted and ready to land.Jan 14 2015, 12:09 AM

also delete access tokens and authorization codes

Closed by commit rP4655b7e4da8e: OAuthServer - implement destructible interface on oauth server client objects (authored by btrahan, committed by btrahan). · Explain WhyJan 14 2015, 12:17 AM

This revision was automatically updated to reflect the committed changes.

Looks like it's working in Instances.

Revision Contents
Changeset List

Path

Size

src/

applications/

oauthserver/

storage/

PhabricatorOAuthServerClient.php

33 lines

Diff 27339

View Options

src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php

OAuthServer - implement destructible interface on oauth server client objectsClosedPublicActions