Page MenuHomePhabricator
Differential D11357

People - add application policy on user creation
ClosedPublic
Actions

Authored by btrahan on Jan 12 2015, 10:44 PM.
Tags
None
Referenced Files
F18807703: D11357.diff
Sun, Oct 19, 3:03 AM
F18783896: D11357.diff
Mon, Oct 13, 10:34 AM
F18763748: D11357.diff
Tue, Oct 7, 2:02 AM
F18760379: D11357.diff
Mon, Oct 6, 9:06 AM
F18729482: D11357.diff
Tue, Sep 30, 11:12 AM
F18729436: D11357.diff
Tue, Sep 30, 11:09 AM
F18659371: D11357.id.diff
Tue, Sep 23, 11:35 AM
F18654942: D11357.diff
Mon, Sep 22, 6:18 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T4137: user_externalaccount table goes out of sync when user try to login before adding it using "import from LDAP"
T6947: Add configuration to lock auth/user creation, or to lock application policies
Commits
Restricted Diffusion Commit
rPe85dfcbeeeb3: People - add application policy on user creation
Summary

Ref T6947.

Test Plan

made the setting say only admin user a and noted admin user b lost access

Diff Detail

Repository
rP Phabricator
Branch
T6947_b
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3801
Build 3813: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 27286.Jan 12 2015, 10:44 PM
btrahan added a task: T6947: Add configuration to lock auth/user creation, or to lock application policies.
btrahan retitled this revision from to People - add application policy on user creation.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 12 2015, 10:44 PM
epriestley accepted this revision.Jan 12 2015, 10:52 PM
epriestley edited edge metadata.
epriestley added a task: T4137: user_externalaccount table goes out of sync when user try to login before adding it using "import from LDAP".

Might need this check in PhabricatorPeopleLdapController too.

Or we could just delete it and close T4137 until T5953.

This revision is now accepted and ready to land.Jan 12 2015, 10:52 PM
btrahan updated this revision to Diff 27288.Jan 12 2015, 11:15 PM
btrahan edited edge metadata.

add the check to ldap controller

Closed by commit rPe85dfcbeeeb3: People - add application policy on user creation (authored by btrahan, committed by btrahan). · Explain WhyJan 12 2015, 11:18 PM
This revision was automatically updated to reflect the committed changes.
• lokinell added a task: T5375: Tokenizers fail in Firefox on Android.Jan 13 2015, 5:20 AM
• lokinell removed a task: T5375: Tokenizers fail in Firefox on Android.

Revision Contents
Changeset List

Diff 27288

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/people/application/PhabricatorPeopleApplication.php

Loading...
View Options

src/applications/people/capability/PeopleCreateUsersCapability.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleCreateController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleLdapController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleNewController.php

Loading...
Phabricator · Built by Phacility