Page MenuHomePhabricator
Differential D11347

Clean up feedback from D11340
ClosedPublic
Actions

Authored by chad on Jan 12 2015, 4:19 PM.
Tags
None
Referenced Files
F14717231: D11347.diff
Fri, Jan 17, 7:27 PM
F14714170: D11347.id27257.diff
Fri, Jan 17, 5:06 PM
F14712407: D11347.id27256.diff
Fri, Jan 17, 3:47 PM
Unknown Object (File)
Thu, Jan 16, 3:11 PM
Unknown Object (File)
Thu, Jan 16, 3:11 PM
Unknown Object (File)
Thu, Jan 16, 3:11 PM
Unknown Object (File)
Sun, Jan 12, 10:29 AM
Unknown Object (File)
Mon, Jan 6, 1:14 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP9f4a3226ea9a: Clean up feedback from D11340
Summary

Ref D11340, I missed the comments being to excited to land.

Test Plan

Shrink window to mobile view, click on action menu.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 27256.Jan 12 2015, 4:19 PM
chad retitled this revision from to Clean up feedback from D11340.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 12 2015, 4:19 PM
epriestley accepted this revision.Jan 12 2015, 4:20 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 12 2015, 4:20 PM
Closed by commit rP9f4a3226ea9a: Clean up feedback from D11340 (authored by chad, committed by chad). · Explain WhyJan 12 2015, 4:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
phui/
21 lines
6 lines
webroot/
rsrc/
css/
phui/
4 lines

Diff 27257

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIButtonView.php

Loading...
View Options

src/view/phui/PHUIObjectBoxView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-header-view.css

Loading...
Phabricator · Built by Phacility