Ref T5752, moves mobile action menus to the object box instead of crumbs.
Details
Details
- Reviewers
epriestley btrahan - Maniphest Tasks
- T5752: Navigation menus should work correctly on mobile by default
- Commits
- Restricted Diffusion Commit
rP790d250967cc: Move ActionList mobile links to better location
View action menus at tablet, desktop, and mobile break points. Verify clicking buttons works as expected opening menu.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- action-menu
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 3776 Build 3787: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Nice!
| src/view/phui/PHUIButtonView.php | ||
|---|---|---|
| 25–27 | Since this class extends AphrontTagView, you shouldn't need to add these yourself. | |
| 93 | (This will be addSigil(), from the superclass.) | |
| 98 | (This will be setMetadata(), from the superclass.) | |
| webroot/rsrc/css/phui/phui-header-view.css | ||
| 151 | Not a big deal, but can we do this without !important? It always seems hacky to me when I see it. | |
Comment Actions
We can do this without important, but in this case that seems more hacky. That is, it takes like 4-5 classes to override it and it may break in the future if it needs more specificity. This path (menu-open) is never likely to be extended and I consider this "final", so seemed cleaner.