Page MenuHomePhabricator
Differential D11339

Fix Aphlict logging
ClosedPublic
Actions

Authored by epriestley on Jan 12 2015, 2:44 AM.
Tags
None
Referenced Files
F18812440: D11339.id27254.diff
Mon, Oct 20, 9:19 AM
F18711921: D11339.diff
Mon, Sep 29, 5:09 AM
F18627476: D11339.id.diff
Sep 16 2025, 4:04 AM
F18607661: D11339.diff
Sep 14 2025, 12:06 AM
F18596393: D11339.diff
Sep 13 2025, 12:35 AM
F18435835: D11339.id27255.diff
Aug 31 2025, 10:28 AM
F18389458: D11339.id27254.diff
Aug 29 2025, 5:48 AM
F18388448: D11339.id27241.diff
Aug 29 2025, 4:27 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
joshuaspence
btrahan
Commits
Restricted Diffusion Commit
rP0d070c91dc8d: Fix Aphlict logging
Summary

Yeahhhhhhhh....

  • Open a "stream", not a "steam".
  • Make error easier for users to understand.
  • Write to the log in debug mode so the issue is more apparent.
Test Plan
  • Started server with bad permissions, got usable error message.
  • Started server with good permissions, got logfile.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27241.Jan 12 2015, 2:44 AM
joshuaspence retitled this revision from to Fix Aphlict logging.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 12 2015, 2:44 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 12 2015, 3:43 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 12 2015, 3:43 PM
epriestley requested changes to this revision.Jan 12 2015, 3:44 PM
epriestley edited edge metadata.

uh pulled the trigger on that a little bit fast

This revision now requires changes to proceed.Jan 12 2015, 3:44 PM
epriestley commandeered this revision.Jan 12 2015, 3:55 PM
epriestley edited reviewers, added: joshuaspence; removed: epriestley.
epriestley updated this revision to Diff 27254.Jan 12 2015, 3:57 PM
epriestley added a reviewer: btrahan.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)

Seems like it was haunted.

epriestley removed a reviewer: Blessed Reviewers.Jan 12 2015, 3:58 PM
btrahan accepted this revision.Jan 12 2015, 4:15 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jan 12 2015, 4:15 PM
Closed by commit rP0d070c91dc8d: Fix Aphlict logging (authored by epriestley, committed by epriestley). · Explain WhyJan 12 2015, 4:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
aphlict/
management/
4 lines
support/
aphlict/
server/
24 lines
lib/
2 lines

Diff 27255

View Options

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php

Loading...
View Options

support/aphlict/server/aphlict_server.js

Loading...
View Options

support/aphlict/server/lib/AphlictLog.js

Loading...
Phabricator · Built by Phacility