Page MenuHomePhabricator

Fix a lint renderering issue
ClosedPublic

Authored by joshuaspence on Jan 11 2015, 9:02 AM.
Tags
None
Referenced Files
F13974010: D11319.diff
Fri, Oct 18, 3:38 AM
F13962559: D11319.id27188.diff
Tue, Oct 15, 10:48 AM
Unknown Object (File)
Fri, Oct 11, 7:27 PM
Unknown Object (File)
Oct 7 2024, 4:21 PM
Unknown Object (File)
Sep 3 2024, 4:26 PM
Unknown Object (File)
Sep 1 2024, 5:46 AM
Unknown Object (File)
Aug 25 2024, 8:56 PM
Unknown Object (File)
Aug 23 2024, 6:18 AM
Subscribers

Details

Summary

Currently there is an issue when renderering linter messages with ArcanistConsoleLintRenderer if $message->getChar() returns 0 (i.e. the value is unset).

Test Plan

Before

lint_renderer_(before) (122×453 px, 8 KB)

After

lint_renderer_(after) (123×308 px, 7 KB)

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Fix a lint renderering issue.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.

Minor whitespace change

epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 11 2015, 4:57 PM
This revision was automatically updated to reflect the committed changes.