Page MenuHomePhabricator

Don't explicitly pass `--color=never` to `coffeelint`
ClosedPublic

Authored by joshuaspence on Jan 11 2015, 7:57 AM.
Tags
None
Referenced Files
F14035007: D11318.diff
Sun, Nov 10, 3:29 AM
F14022285: D11318.diff
Wed, Nov 6, 4:04 PM
F13999935: D11318.diff
Thu, Oct 24, 6:08 PM
F13995824: D11318.id27220.diff
Wed, Oct 23, 3:54 PM
F13989929: D11318.id27220.diff
Mon, Oct 21, 11:58 PM
Unknown Object (File)
Oct 4 2024, 2:11 PM
Unknown Object (File)
Sep 22 2024, 2:53 AM
Unknown Object (File)
Sep 1 2024, 11:22 AM
Subscribers

Details

Summary

This flag doesn't do anything in combination with --reporter=checkstyle.

Test Plan
> coffeelint --reporter=checkstyle test.coffee
<?xml version="1.0" encoding="utf-8"?>
<checkstyle version="4.3">
<file name="test.coffee">
<error line="1"
    severity="error"
    message="Class names should be camel cased; context: class name: boaConstrictor"
    source="coffeelint"/>
</file>
</checkstyle>

> coffeelint --reporter=checkstyle --color=never test.coffee
<?xml version="1.0" encoding="utf-8"?>
<checkstyle version="4.3">
<file name="test.coffee">
<error line="1"
    severity="error"
    message="Class names should be camel cased; context: class name: boaConstrictor"
    source="coffeelint"/>
</file>
</checkstyle>

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Don't explcitly pass `--color=never` to `coffeelint`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 11 2015, 4:56 PM
joshuaspence retitled this revision from Don't explcitly pass `--color=never` to `coffeelint` to Don't explicitly pass `--color=never` to `coffeelint`.Jan 11 2015, 7:48 PM
joshuaspence edited edge metadata.
This revision was automatically updated to reflect the committed changes.