Page MenuHomePhabricator

Allow `PhabricatorRepositoryCommitHeraldWorker` to continue on certain types of exceptions
ClosedPublic

Authored by joshuaspence on Jan 9 2015, 10:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 12:16 AM
Unknown Object (File)
Sun, Mar 24, 12:10 AM
Unknown Object (File)
Sun, Mar 24, 12:09 AM
Unknown Object (File)
Sat, Mar 23, 10:54 PM
Unknown Object (File)
Sat, Mar 23, 10:27 PM
Unknown Object (File)
Sat, Mar 23, 2:12 PM
Unknown Object (File)
Sat, Mar 23, 12:36 PM
Unknown Object (File)
Sat, Mar 23, 11:51 AM
Subscribers

Details

Summary

Fixes T6922. We should allow the commit pipeline to continue on certain types of exceptions, including PhabricatorApplicationTransactionNoEffectException.

Test Plan

Before

> ./bin/repository reparse --herald rP2660b944bed4e4dde3e66303656b1d96d8b03e9b
[2015-01-10 09:38:06] EXCEPTION: (PhabricatorApplicationTransactionNoEffectException) Transactions have no effect:
  - Edges already exist; transaction has no effect. at [<phabricator>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1635]
  #0 PhabricatorApplicationTransactionEditor::filterTransactions(PhabricatorRepositoryCommit, array) called at [<phabricator>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:649]
  #1 PhabricatorApplicationTransactionEditor::applyTransactions(PhabricatorRepositoryCommit, array) called at [<phabricator>/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php:91]
  #2 PhabricatorRepositoryCommitHeraldWorker::parseCommit(PhabricatorRepository, PhabricatorRepositoryCommit) called at [<phabricator>/src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php:44]
  #3 PhabricatorRepositoryCommitParserWorker::doWork() called at [<phabricator>/src/infrastructure/daemon/workers/PhabricatorWorker.php:91]
  #4 PhabricatorWorker::executeTask() called at [<phabricator>/src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php:297]
  #5 PhabricatorRepositoryManagementReparseWorkflow::execute(PhutilArgumentParser) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:396]
  #6 PhutilArgumentParser::parseWorkflowsFull(array) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:292]
  #7 PhutilArgumentParser::parseWorkflows(array) called at [<phabricator>/scripts/repository/manage_repositories.php:22]

After

> ./bin/repository reparse --herald rP2660b944bed4e4dde3e66303656b1d96d8b03e9b
Done.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Allow `PhabricatorRepositoryCommitHeraldWorker` to continue on certain types of exceptions.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 9 2015, 10:42 PM
This revision was automatically updated to reflect the committed changes.