Paths

Table of Contentst

Differential D11304

Allow `PhabricatorRepositoryCommitHeraldWorker` to continue on certain types of exceptions
ClosedPublic
Actions

Authored by joshuaspence on Jan 9 2015, 10:41 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6922: Diffusion git repository import stuck at 99.99%

Commits

Restricted Diffusion Commit
rP9b21274138cf: Allow `PhabricatorRepositoryCommitHeraldWorker` to continue on certain types…

Summary

Fixes T6922. We should allow the commit pipeline to continue on certain types of exceptions, including PhabricatorApplicationTransactionNoEffectException.

Test Plan

Before

> ./bin/repository reparse --herald rP2660b944bed4e4dde3e66303656b1d96d8b03e9b
[2015-01-10 09:38:06] EXCEPTION: (PhabricatorApplicationTransactionNoEffectException) Transactions have no effect:
  - Edges already exist; transaction has no effect. at [<phabricator>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1635]
  #0 PhabricatorApplicationTransactionEditor::filterTransactions(PhabricatorRepositoryCommit, array) called at [<phabricator>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:649]
  #1 PhabricatorApplicationTransactionEditor::applyTransactions(PhabricatorRepositoryCommit, array) called at [<phabricator>/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php:91]
  #2 PhabricatorRepositoryCommitHeraldWorker::parseCommit(PhabricatorRepository, PhabricatorRepositoryCommit) called at [<phabricator>/src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php:44]
  #3 PhabricatorRepositoryCommitParserWorker::doWork() called at [<phabricator>/src/infrastructure/daemon/workers/PhabricatorWorker.php:91]
  #4 PhabricatorWorker::executeTask() called at [<phabricator>/src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php:297]
  #5 PhabricatorRepositoryManagementReparseWorkflow::execute(PhutilArgumentParser) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:396]
  #6 PhutilArgumentParser::parseWorkflowsFull(array) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:292]
  #7 PhutilArgumentParser::parseWorkflows(array) called at [<phabricator>/scripts/repository/manage_repositories.php:22]

After

> ./bin/repository reparse --herald rP2660b944bed4e4dde3e66303656b1d96d8b03e9b
Done.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27160.Jan 9 2015, 10:41 PM

joshuaspence retitled this revision from to Allow `PhabricatorRepositoryCommitHeraldWorker` to continue on certain types of exceptions.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6922: Diffusion git repository import stuck at 99.99%.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 9 2015, 10:41 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 9 2015, 10:42 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 9 2015, 10:42 PM

Closed by commit rP9b21274138cf: Allow `PhabricatorRepositoryCommitHeraldWorker` to continue on certain types… (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 9 2015, 10:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

worker/

PhabricatorRepositoryCommitHeraldWorker.php

2 lines

Diff 27161

View Options

src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php

Allow `PhabricatorRepositoryCommitHeraldWorker` to continue on certain types of exceptionsClosedPublicActions