Page MenuHomePhabricator
Differential D11300

T6856 Make Project Images that match Typeahead choices
ClosedPublic
Actions

Authored by lpriestley on Jan 9 2015, 9:28 PM.
Tags
None
Referenced Files
F13178827: D11300.diff
Wed, May 8, 8:43 PM
Unknown Object (File)
Sat, May 4, 6:24 PM
Unknown Object (File)
Tue, Apr 30, 11:14 PM
Unknown Object (File)
Sat, Apr 27, 10:27 AM
Unknown Object (File)
Wed, Apr 17, 2:26 PM
Unknown Object (File)
Wed, Apr 10, 4:21 PM
Unknown Object (File)
Apr 8 2024, 12:18 AM
Unknown Object (File)
Apr 8 2024, 12:18 AM
View All Files
Subscribers
btrahan
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6856: Make Project Images that match Typeahead choices
Commits
Restricted Diffusion Commit
rP9853ff2cff3b: T6856 Make Project Images that match Typeahead choices
Summary

Ref T6856, Make matching Project picture to Project icon easy.

Test Plan

Edit Project, edit Project picture, click "Use Project Icon", Project picture should now match Project icon.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 27152.Jan 9 2015, 9:28 PM
lpriestley retitled this revision from to T6856 Make Project Images that match Typeahead choices.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added reviewers: epriestley, chad.
lpriestley added a task: T6856: Make Project Images that match Typeahead choices.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 9 2015, 9:28 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
chad added inline comments.Jan 9 2015, 9:35 PM
src/applications/files/controller/PhabricatorFileComposeController.php
19

!!!

lpriestley added inline comments.Jan 10 2015, 7:32 AM
src/applications/files/controller/PhabricatorFileComposeController.php
19

Haha. Yeah. Probably need official copy for that.

chad added inline comments.Jan 10 2015, 3:40 PM
src/applications/files/controller/PhabricatorFileComposeController.php
19

Seems correctly official!

epriestley added inline comments.Jan 10 2015, 5:56 PM
src/applications/files/controller/PhabricatorFileComposeController.php
19

Official copy is "Easter Lily".

btrahan added a subscriber: btrahan.Jan 10 2015, 10:27 PM
btrahan added inline comments.
src/applications/files/controller/PhabricatorFileComposeController.php
19

Easter Lily is white. i think this color is Easter Bunny

epriestley accepted this revision.Jan 11 2015, 5:40 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 11 2015, 5:40 PM
Closed by commit rP9853ff2cff3b: T6856 Make Project Images that match Typeahead choices (authored by lpriestley, committed by epriestley). · Explain WhyJan 11 2015, 5:41 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D11332: Update Celerity map.Jan 11 2015, 9:06 PM

Revision Contents
Changeset List

PathSize
src/
applications/
files/
controller/
114 lines
project/
controller/
32 lines
webroot/
rsrc/
css/
application/
people/
4 lines

Diff 27203

View Options

src/applications/files/controller/PhabricatorFileComposeController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectEditPictureController.php

Loading...
View Options

webroot/rsrc/css/application/people/people-profile.css

Loading...
Phabricator · Built by Phacility