Paths

Table of Contentst

Differential D11288

Allow the Aphlict server to bind to localhost
ClosedPublic
Actions

Authored by joshuaspence on Jan 8 2015, 11:08 PM.

Tags

None

Referenced Files

	F13051923: D11288.diff
	Fri, Apr 19, 5:40 AM

	F13049472: D11288.id27128.diff
	Fri, Apr 19, 2:13 AM

	F13049471: D11288.id27121.diff
	Fri, Apr 19, 2:13 AM

	F13049470: D11288.id.diff
	Fri, Apr 19, 2:13 AM

	Unknown Object (File)
	Tue, Apr 16, 5:14 AM

	Unknown Object (File)
	Thu, Apr 11, 3:36 AM

	Unknown Object (File)
	Fri, Mar 22, 4:17 AM

	Unknown Object (File)
	Feb 14 2024, 11:25 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6559: Change notification system implementation not to require Flash

Commits

Restricted Diffusion Commit
rP638cf20c9de4: Allow the Aphlict server to bind to localhost

Summary

If you are running the Aphlict server behind a reverse proxy (such as nginx) then there's no need to bind to 0.0.0.0. Add a --client-host flag to aphlict_server.js to allow binding to a different hostname. Also changed the other flags for consistency and clarity.

Test Plan

Started, stopped and debug the Aphlict server.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27121.Jan 8 2015, 11:08 PM

joshuaspence retitled this revision from to Allow the Aphlict server to bind to localhost.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 8 2015, 11:08 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 8 2015, 11:55 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/aphlict/management/PhabricatorAphlictManagementRestartWorkflow.php
12–16	Maybe move this spec into the superclass?
support/aphlict/server/aphlict_server.js
12–16	This cleanup is nice.

This revision is now accepted and ready to land.Jan 8 2015, 11:55 PM

joshuaspence added inline comments.Jan 9 2015, 12:00 AM

src/applications/aphlict/management/PhabricatorAphlictManagementRestartWorkflow.php
12–16	Sure. This might be problematic if any of the workflows want to implement their own arguments, but we can deal with this later.

Yeah, we can always array_merge($this_args, $this->getCommonServerArgs()) or whatever.

Closed by commit rP638cf20c9de4: Allow the Aphlict server to bind to localhost (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 9 2015, 12:11 AM

This revision was automatically updated to reflect the committed changes.

joshuaspence added a task: T6559: Change notification system implementation not to require Flash.Jan 9 2015, 12:28 AM

joshuaspence mentioned this in D11359: Add `notification.bind-uri` to configure Aphlict server.Jan 13 2015, 7:41 AM

joshuaspence mentioned this in D11423: Don't pass `--admin-host` to the Aphlict server.Jan 19 2015, 7:48 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

aphlict/

management/

PhabricatorAphlictManagementDebugWorkflow.php

11 lines

PhabricatorAphlictManagementRestartWorkflow.php

6 lines

PhabricatorAphlictManagementStartWorkflow.php

5 lines

PhabricatorAphlictManagementWorkflow.php

54 lines

support/

aphlict/

server/

aphlict_server.js

22 lines

Diff 27128

src/applications/aphlict/management/PhabricatorAphlictManagementDebugWorkflow.php

Loading...

src/applications/aphlict/management/PhabricatorAphlictManagementRestartWorkflow.php

Loading...

src/applications/aphlict/management/PhabricatorAphlictManagementStartWorkflow.php

Loading...

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php

Loading...

support/aphlict/server/aphlict_server.js

Loading...