Page MenuHomePhabricator

Allow the Aphlict server to bind to localhost
ClosedPublic

Authored by joshuaspence on Jan 8 2015, 11:08 PM.

Details

Summary

If you are running the Aphlict server behind a reverse proxy (such as nginx) then there's no need to bind to 0.0.0.0. Add a --client-host flag to aphlict_server.js to allow binding to a different hostname. Also changed the other flags for consistency and clarity.

Test Plan

Started, stopped and debug the Aphlict server.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joshuaspence retitled this revision from to Allow the Aphlict server to bind to localhost.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley accepted this revision.Jan 8 2015, 11:55 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/aphlict/management/PhabricatorAphlictManagementRestartWorkflow.php
12–16

Maybe move this spec into the superclass?

support/aphlict/server/aphlict_server.js
12–16

This cleanup is nice.

This revision is now accepted and ready to land.Jan 8 2015, 11:55 PM
joshuaspence added inline comments.Jan 9 2015, 12:00 AM
src/applications/aphlict/management/PhabricatorAphlictManagementRestartWorkflow.php
12–16

Sure. This might be problematic if any of the workflows want to implement their own arguments, but we can deal with this later.

Yeah, we can always array_merge($this_args, $this->getCommonServerArgs()) or whatever.

This revision was automatically updated to reflect the committed changes.