Page MenuHomePhabricator

Don't show notifications about your own actions
ClosedPublic

Authored by epriestley on Jan 8 2015, 7:52 AM.

Details

Summary

Ref T6559. See discussion in D11143. At least locally, WebSockets are too fast and create immediate local notifications on page submit.

To mitigate this, don't notify about your own actions.

This isn't perfect (we get the other-copies-of-the-window-open-in-other-tabs case wrong) but I think the case we get wrong is rare / not very important.

Test Plan

Submitted stuff, saw other users get notifications but not me.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't show notifications about your own actions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
This revision is now accepted and ready to land.Jan 8 2015, 7:56 AM
This revision was automatically updated to reflect the committed changes.