Differential D11274
Make getHeader, getBody and getFooter members public on PhutilConsoleTable Authored by hach-que on Jan 8 2015, 7:02 AM. Tags None Referenced Files
Subscribers
Details
This makes the getHeader, getBody and getFooter members public on PhutilConsoleTable instead of protected. In Omni, we route all of the standard output from builtins through pipes, not the standard output normally obtained using echo or any of phutil's console functionality. As such, when using the PhutilConsoleTable class I need some way of getting the strings that make up the table instead of just calling draw. Currently used within Omni to access those members.
Diff Detail
Event TimelineComment Actions I'll accept a render() or something which draw() calls internally. This change doesn't seem like a good fit for the use case (which does not require separate access to the header, body and footer). |