Paths

Table of Contentst

Simplify version parsing for `ArcanistPhpLinter`
ClosedPublic
Actions

Authored by joshuaspence on Jan 7 2015, 8:35 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 11:49 PM

	Unknown Object (File)
	Thu, Dec 19, 12:37 AM

	Unknown Object (File)
	Thu, Dec 12, 9:25 PM

	Unknown Object (File)
	Wed, Dec 11, 10:15 AM

	Unknown Object (File)
	Sat, Dec 7, 3:28 PM

	Unknown Object (File)
	Fri, Dec 6, 9:43 AM

	Unknown Object (File)
	Wed, Dec 4, 9:59 AM

	Unknown Object (File)
	Tue, Dec 3, 4:15 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC2ad2c04774e2: Simplify version parsing for `ArcanistPhpLinter`

Summary

We can use php --run "echo phpversion();" to return a nice, compact representation of the PHP version.

Test Plan

arc unit

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27061.Jan 7 2015, 8:35 AM

joshuaspence retitled this revision from to Simplify version parsing for `ArcanistPhpLinter`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 7 2015, 8:35 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Remove whitespace

epriestley accepted this revision.Jan 7 2015, 12:53 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 7 2015, 12:53 PM

Closed by commit rARC2ad2c04774e2: Simplify version parsing for `ArcanistPhpLinter` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 7 2015, 1:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistPhpLinter.php

14 lines

Diff 27069

View Options

src/lint/linter/ArcanistPhpLinter.php

Simplify version parsing for `ArcanistPhpLinter`ClosedPublicActions