Fixes T6846, cleans up spacing, makes it look scary red.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T6846: Touch up Exception UI
- Commits
- Restricted Diffusion Commit
rP800b3b030f1c: Basic style for exception page
Fake an exception, see new layout
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- exception-page
- Lint
Lint Errors Severity Location Code Message Error webroot/rsrc/css/application/config/unhandled-exception.css:20 TXT2 Tab Literal Warning webroot/rsrc/css/application/config/unhandled-exception.css:20 TXT3 Line Too Long - Unit
No Test Coverage - Build Status
Buildable 3501 Build 3509: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
One minor thing.
| webroot/rsrc/css/application/config/unhandled-exception.css | ||
|---|---|---|
| 20 | We can't use images on this page. These exceptions include cases where the server is broken and the image won't work. Since this CSS file also isn't interpreted by the CSS preprocessor, it also won't get rewritten, and won't work on any server which is configured according to modern rules (you may have an older ruleset locally which made this directory web-serveable). | |
Comment Actions
I also anticipate this showing some stuff like "This instance is down for scheduled maintenance." in a Phacility environment (and it can currently show errors like "There's no instance here, visit phacility.com to register one."), which we might want to look less ominous. I could add scary and non-scary versions of the error page, though -- many of these errors are bad/severe.