Page MenuHomePhabricator

Basic style for exception page
ClosedPublic

Authored by chad on Jan 2 2015, 9:37 PM.
Tags
None
Referenced Files
F14002325: D11161.id26784.diff
Fri, Oct 25, 5:55 PM
F13996445: D11161.diff
Wed, Oct 23, 9:13 PM
F13961294: D11161.id.diff
Tue, Oct 15, 4:18 AM
Unknown Object (File)
Oct 2 2024, 6:35 AM
Unknown Object (File)
Oct 1 2024, 9:27 AM
Unknown Object (File)
Sep 24 2024, 5:14 PM
Unknown Object (File)
Sep 24 2024, 4:56 PM
Unknown Object (File)
Sep 2 2024, 5:32 PM
Subscribers

Details

Reviewers
epriestley
Maniphest Tasks
T6846: Touch up Exception UI
Commits
Restricted Diffusion Commit
rP800b3b030f1c: Basic style for exception page
Summary

Fixes T6846, cleans up spacing, makes it look scary red.

Test Plan

Fake an exception, see new layout

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Basic style for exception page.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

One minor thing.

webroot/rsrc/css/application/config/unhandled-exception.css
20

We can't use images on this page. These exceptions include cases where the server is broken and the image won't work.

Since this CSS file also isn't interpreted by the CSS preprocessor, it also won't get rewritten, and won't work on any server which is configured according to modern rules (you may have an older ruleset locally which made this directory web-serveable).

This revision now requires changes to proceed.Jan 2 2015, 9:40 PM

I also anticipate this showing some stuff like "This instance is down for scheduled maintenance." in a Phacility environment (and it can currently show errors like "There's no instance here, visit phacility.com to register one."), which we might want to look less ominous. I could add scary and non-scary versions of the error page, though -- many of these errors are bad/severe.

chad edited edge metadata.
  • base-64 encode image
chad edited edge metadata.
  • Remove old image

This isn't like super-scary red. But I could add a violet version for "informative".

epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 2 2015, 9:47 PM
This revision was automatically updated to reflect the committed changes.