Paths

Table of Contentst

Differential D11122

Suppress stdin message if input is piped
ClosedPublic
Actions

Authored by joshuaspence on Jan 1 2015, 12:22 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC0352db802e9d: Suppress stdin message if input is piped

Summary

Currently we output "Waiting for JSON parameters on stdin...", even if stdin is piped (for example, from echo).

Test Plan

> echo '{}' | arc call-conduit conduit.ping
{"error":null,"errorMessage":null,"response":"ip-10-161-81-110"}

> arc call-conduit conduit.ping
Waiting for JSON parameters on stdin...
{}
^D
{"error":null,"errorMessage":null,"response":"ip-10-161-81-110"}

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26700.Jan 1 2015, 12:22 PM

joshuaspence retitled this revision from to Suppress stdin message if input is piped.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 1 2015, 12:22 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

NOTE: This assumes that the POSIX extension is installed.

joshuaspence updated this object.Jan 1 2015, 12:30 PM

joshuaspence edited edge metadata.

I believe we don't require posix, and I don't want to require it. You can do this:

if (!function_exists('posix_isatty') || posix_isatty(STDIN)) {
  // print message
}

This revision now requires changes to proceed.Jan 1 2015, 2:35 PM

Don't require the POSIX extension

epriestley accepted this revision.Jan 1 2015, 11:27 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 1 2015, 11:27 PM

Closed by commit rARC0352db802e9d: Suppress stdin message if input is piped (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 2 2015, 12:37 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistCallConduitWorkflow.php

6 lines

Diff 26741

View Options

src/workflow/ArcanistCallConduitWorkflow.php

Suppress stdin message if input is pipedClosedPublicActions