Page MenuHomePhabricator
Differential D11118

Remove some old code handling the absence of the `file.uploadhash` Conduit method
ClosedPublic
Actions

Authored by joshuaspence on Jan 1 2015, 6:57 AM.
Tags
None
Referenced Files
F14006902: D11118.diff
Mon, Oct 28, 8:38 PM
F14003866: D11118.id26696.diff
Sat, Oct 26, 11:44 AM
F14001657: D11118.id26727.diff
Fri, Oct 25, 10:43 AM
F13974111: D11118.diff
Fri, Oct 18, 4:08 AM
Unknown Object (File)
Sep 30 2024, 8:40 PM
Unknown Object (File)
Sep 24 2024, 6:10 AM
Unknown Object (File)
Sep 14 2024, 10:53 PM
Unknown Object (File)
Sep 14 2024, 10:52 PM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCf86a70f411df: Remove some old code handling the absence of the `file.uploadhash` Conduit…
Summary

The file.uploadhash method was added a long time ago (in D4899). It should be safe to assume that this method exists on most installs.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26696.Jan 1 2015, 6:57 AM
joshuaspence retitled this revision from to Remove some old code.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 1 2015, 6:57 AM
Herald added a subscriber: epriestley. · View Herald Transcript
joshuaspence retitled this revision from Remove some old code to Remove some old code handling the absence of the `file.uploadhash` Conduit method.Jan 1 2015, 11:58 AM
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.
joshuaspence added a reviewer: epriestley.
epriestley accepted this revision.Jan 1 2015, 2:31 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/workflow/ArcanistDiffWorkflow.php
2538–2541

We recover anyway, so this should never do anythign bad.

This revision is now accepted and ready to land.Jan 1 2015, 2:31 PM
Closed by commit rARCf86a70f411df: Remove some old code handling the absence of the `file.uploadhash` Conduit… (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 1 2015, 11:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
workflow/
64 lines

Diff 26727

View Options

src/workflow/ArcanistDiffWorkflow.php

Loading...
Phabricator · Built by Phacility